Commit graph

231 commits

Author SHA1 Message Date
Matt Pocock
8010ddb2bb docs: thread code-review through the full build-chain flow
The build chain now ends at code-review. Update every flow doc that draws
the chain so it reads end-to-end:

    grill-with-docs → to-prd → to-issues → implement → code-review

- grill-with-docs / to-prd / to-issues: extend the diagram; point the
  downstream neighbour at implement (which drives tdd internally).
- tdd: reframe from "final step" to the engine inside implement's step.
- implement: extend the diagram to include the review pass.
- ask-matt: narrate the flow ending in review (docs) and note that
  /implement closes out with /code-review (SKILL.md).
- writing-docs guide: refresh the example chain.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-01 12:05:16 +01:00
Matt Pocock
14c13c5bf9 Rename review skill to code-review and promote to engineering
Rename the in-progress `review` skill to `code-review` and move it from
`skills/in-progress/` into the promoted `skills/engineering/` bucket.

- Add it to `.claude-plugin/plugin.json` and the Model-invoked sections of
  the top-level and Engineering READMEs; drop it from the in-progress README.
- Add a docs page at `docs/engineering/code-review.md`.
- Point `/implement` and its docs at `/code-review`.
- Update the smell-baseline changeset reference; add a changeset for the move.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-01 12:04:12 +01:00
Matt Pocock
5a4191541c
Merge pull request #404 from mattpocock/docs/chain-ends-at-implement
docs: end the build chain at implement, not tdd
2026-07-01 11:44:01 +01:00
Matt Pocock
f72b3d5bd4 docs: end the build chain at implement, not tdd
The canonical build chain is grill-with-docs → to-prd → to-issues →
implement, with tdd as the red-green loop implement drives internally
rather than a chain step of its own.

- Update the chain diagram on grill-with-docs, to-prd, to-issues, and tdd.
- Reframe tdd's "Where it fits": it's the engine inside the implement
  step, still independently reachable, no longer the terminal.
- Point to-prd and to-issues at implement as the thing that builds the
  tickets, giving implement the inbound links it previously lacked.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 11:43:08 +01:00
Matt Pocock
b8c052f56e
Merge pull request #403 from mattpocock/docs/skill-pages-remaining
docs: pages for the remaining 22 promoted skills
2026-07-01 11:37:56 +01:00
Matt Pocock
7efc3d2a38 misc: demote to a non-promoted bucket
misc/ skills are no longer installable via the plugin or listed in the
top-level README — they join personal/ as kept-but-unshipped. Only
engineering/ and productivity/ are promoted now.

- Drop the Misc section from the top-level README.
- Reclassify misc/ as non-promoted in CLAUDE.md (README/plugin rule,
  bucket-README grouping rule, docs-page rule) and the writing-docs guide.
- Note the non-promoted status in the misc bucket README.

plugin.json already omitted misc, so no manifest change was needed.
No SKILL.md context pointer referenced a misc skill, so nothing else
had to move.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 11:36:37 +01:00
Matt Pocock
8fa032a8fd docs: exclude misc/ skills from the public docs
misc/ skills are niche — they stay promoted (README + plugin manifest,
so they're installable) but no longer get a public aihero.dev docs
page. Remove the four misc pages and decouple the docs rule from the
promotion rule in CLAUDE.md and the writing-docs guide.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 11:31:29 +01:00
Matt Pocock
ade35dc0d8 docs: drop the formulaic "load-bearing constraint:" label
The repeated "The load-bearing constraint:" opener on every page read
as an agent tell. Strip the label across all skill pages and let the
constraint stand as a plain declarative sentence; update the
writing-docs template so it isn't regenerated.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 11:27:36 +01:00
Matt Pocock
995fceec7a docs: name the reference skills other skills lean on
codebase-design, domain-modeling and grilling are pulled out as
standalone, model-invoked skills precisely so other skills can point
at them and so you can reach them as a reference independently of the
steps any wrapper mandates. Add a "Pulled out on purpose" section to
each that names who leans on it and why it stands alone, and slim the
overlapping "Where it fits" prose to avoid duplication.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 11:27:36 +01:00
Matt Pocock
f5ed5657bd docs: add human-facing pages for the remaining 22 promoted skills
Adds a docs page for every promoted skill that lacked one, following
.agents/writing-docs.md and using docs/engineering/to-prd.md as the
worked exemplar. Covers all of engineering/ (bar to-prd, already done),
productivity/, and misc/.

Each page states its load-bearing constraint, its invocation mode and
trigger boundary, surfaces the skill's leading word, and routes back to
ask-matt so the set forms a connected router with no dead ends.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 11:18:17 +01:00
Matt Pocock
5694f83609
Merge pull request #402 from mattpocock/docs/skill-pages-template
docs: rework the skill docs-page template
2026-07-01 11:08:07 +01:00
Matt Pocock
340d01b145 docs: add "It's working if" convention; flesh out PRD section
- Replace the inline "watch for the leading words" line with an
  optional `## It's working if` section — a short list of observable
  signals the skill is doing its job. Keeps observability from being
  hammered onto leading words specifically.
- Build out to-prd's "What the PRD includes" with proper casing and a
  one-line explainer per section.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 11:05:35 +01:00
Matt Pocock
77cc47773c docs: rework the skill docs-page template
Reframe docs pages around cognitive-load relief: most skills are
user-invoked, so the human is the index that must remember when to
reach for each one. Each page's job is to make one skill memorable
and situate it in the system.

Template changes (.agents/writing-docs.md):
- Quickstart block: install + `npx skills update`, install-first
- New `## When to reach for it` (invocation mode + trigger boundary)
- New optional `## Prerequisites` (workspace/state, prior setup, tooling)
- Free-form middle with one firm rule: surface the leading word
  (also an observability signal in the agent's output)
- `## Where it fits`: role-based, absorbs "Pairs well with", links ask-matt
- No H1; every cross-link absolute

Nest docs under bucket folders (docs/<bucket>/<name>.md); the
published URL stays skills-<name> regardless. Re-sync to-prd as the
worked exemplar.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 11:00:54 +01:00
Matt Pocock
ca85062d46
Merge pull request #401 from mattpocock/decision-mapping-task-type
Add Task ticket type to decision-mapping skill
2026-07-01 10:44:06 +01:00
Matt Pocock
64d9f3d49e Add Task ticket type to decision-mapping skill
Some blockers are neither a decision, a prototype, nor research — just
literal manual work (moving data, signing up for a service, provisioning
access) that must happen before discussion can move forward.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 10:41:51 +01:00
Matt Pocock
7c1d609ce2 Add documentation guidelines for skill pages and update CLAUDE.md references 2026-07-01 09:57:05 +01:00
Matt Pocock
72748b9519 Fix command syntax in to-prd installation instructions 2026-07-01 09:51:25 +01:00
Matt Pocock
94cac3a3c7 Fix links in the to-prd documentation for better accessibility 2026-07-01 09:50:21 +01:00
Matt Pocock
3525dcd9b2 Add documentation for the to-prd skill 2026-07-01 09:48:39 +01:00
Matt Pocock
6e178c6826 Move docs/ into .agents/
Relocate this repo's ADRs and invocation.md from docs/ to .agents/,
and update the CLAUDE.md reference.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-01 09:46:14 +01:00
Matt Pocock
0877403d1e
Merge pull request #398 from mattpocock/generalize-decision-mapping
Generalize decision-mapping beyond engineering
2026-06-30 18:45:31 +01:00
Matt Pocock
575d14b806 Trim Notes block to its definition (cut no-op behavioral prose)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 18:44:56 +01:00
Matt Pocock
79a5c9cc55 Keep Prototype name; move Notes block to end of map
- Revert Sketch back to Prototype to mesh with the /prototype skill and
  existing vocabulary, keeping the generalized function-first definition.
- Move the `## Notes` block from the top of the map to the end.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 18:40:52 +01:00
Matt Pocock
3dc6800550 Generalize decision-mapping beyond engineering
Decouple the skill from engineering so it plans any domain (e.g. course
content) without specializing toward it. Domain specifics live in the map,
not the skill body.

- Add an optional `## Notes` block to the map: declares the domain + skills
  to consult, plus freeform standing preferences. Loaded into every session,
  honored by every session, accrues as it emerges.
- Rename the Prototype ticket type to Sketch and define it by function —
  raise the fidelity of the discussion with a cheap concrete artifact to
  react to (/prototype is one medium among outline/rough-take/stub).
- Note that validation is the thread through all three types, not a type.
- Resolve step now consults skills named in Notes.

The session machinery (one ticket per session, claiming, parallelism,
handoff) is unchanged — it follows from the AI agent's smart/dumb zones, not
the domain.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 18:38:34 +01:00
Matt Pocock
801dca6885 docs(CLAUDE.md): point to scripts/link-skills.sh for (re)linking skills
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 11:36:43 +01:00
Matt Pocock
999745ead1
Merge pull request #395 from mattpocock/dev-only-link-skills-note
docs(link-skills): mark as a dev-only script
2026-06-30 10:29:36 +01:00
Matt Pocock
6b8c429bc6 docs(link-skills): mark as a dev-only script
Add a header note clarifying that link-skills.sh is a dev-only script for
maintainers, not a supported installer, and that modifications or requests
for modification will not be approved.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 10:28:50 +01:00
Matt Pocock
7936cd4b8b
Merge pull request #394 from mattpocock/review-smell-baseline
feat(review): always-on Fowler smell baseline in the Standards axis
2026-06-30 10:24:14 +01:00
Matt Pocock
7a4c7561d4 Add changeset for review smell baseline
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 10:19:49 +01:00
Matt Pocock
0894b3300f review: add a terse fix to each smell in the baseline
Each smell now reads what-it-is → how-to-fix, telegraphic style — the fix
is the actionable half a reviewer needs, kept to a clause.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 10:02:31 +01:00
Matt Pocock
cac470445b feat(review): add an always-on Fowler smell baseline to the Standards axis
Folds Refactoring ch.3 "Bad Smells in Code" into the in-progress `review`
skill. The skill stays two-axis: smells layer into the Standards axis as a
fixed, always-on baseline alongside a repo's documented standards, rather
than a third axis.

Because the baseline is needed on every run it lives inline in SKILL.md.
Each smell is one line — its name carries the definition (the names are
strong leading words) plus a diff-specific cue. Curated to ~12 high-signal
smells; vague ones (Comments, Loops) and tooling-caught ones (Long
Parameter List) are deliberately dropped.

Two rules bind the baseline: a documented repo standard always overrides
it, and every smell is reported as a judgement call, never a hard
violation. The Standards sub-agent prompt now carries the baseline and
these rules.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 09:58:26 +01:00
Matt Pocock
80e9dcc685 tdd: drop the refactor stage — red → green, not red → green → refactor
Refactoring belongs to the review stage, not the implementation loop.
Remove the refactor rule and the now-orphaned refactoring.md (its home is
the review skill), and point the loop's rule at the review skill so it
isn't re-added.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 09:48:57 +01:00
Matt Pocock
e81f97660a tdd: reshape into reference-only with pre-agreed seams
The red → green → refactor loop is anchored by leading words the model
already holds, so the step-by-step Workflow mostly restated the loop and
duplicated the horizontal-slicing anti-pattern. Drop the Workflow and
per-cycle checklist; fold their durable idea (vertical slices / tracer
bullets) into Anti-patterns and a short Rules-of-the-loop list.

Introduce **seam** as the leading word for where tests go, collapsing the
old Philosophy "public interfaces" prose and the Planning "confirm
interface / behaviors" handshake into one rule: test only at pre-agreed
seams, confirmed with the user before any test is written.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-30 09:43:49 +01:00
Matt Pocock
43ea0884b0 tdd: add tautological-test anti-pattern
Tests whose assertion is recomputed the way the code computes it pass by
construction and give zero confidence. Add it as a peer of the existing
implementation-coupling anti-pattern: a Philosophy principle, a per-cycle
checklist gate, and a BAD/GOOD example pair in tests.md. Includes a patch
changeset.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-29 21:22:50 +01:00
Matt Pocock
a116824938 decision-mapping: key tickets by dash-case slugs, not numeric ids
Replace numeric ticket ids (#1, #2…) with short, token-efficient
dash-case slugs (e.g. relational-db) that read as mini-titles. Update
the Structure example, the next-ticket selection rule (lowest-numbered →
first in document order), the optional-arg wording, and the Handoff
copy-paste examples accordingly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-29 16:50:46 +01:00
Matt Pocock
448d0adee7 Merge branch 'main' of https://github.com/mattpocock/skills
# Conflicts:
#	skills/in-progress/decision-mapping/SKILL.md
2026-06-29 13:53:15 +01:00
Matt Pocock
850873cd73 feat: implement model-invoked prototype skill and enhance wizard functionality 2026-06-29 13:51:38 +01:00
Matt Pocock
5d78bd0903 fix: correct spelling of 'domain-modeling' in decision-mapping documentation 2026-06-25 12:48:23 +01:00
Matt Pocock
78636f8e5c Updated writing-* skills 2026-06-25 11:57:14 +01:00
Matt Pocock
8370e760d0 refactor: enhance glossary clarity and structure 2026-06-24 11:29:44 +01:00
Matt Pocock
74f0450b9c Link skills into ~/.agents/skills as well as ~/.claude/skills
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 11:27:21 +01:00
Matt Pocock
c71fce0297 Refine decision-mapping bootstrap step
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 11:26:57 +01:00
Matt Pocock
e95b1813c5 Move loop-me into in-progress
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-24 11:26:57 +01:00
Matt Pocock
42396a51d6 fix: update ticket type terminology from "Discuss" to "Grilling" 2026-06-22 13:15:30 +01:00
Matt Pocock
6eeb81b5fc Merge branch 'main' of https://github.com/mattpocock/skills 2026-06-18 09:41:33 +01:00
Matt Pocock
e00eadb4bb Added PR's as a triage surface 2026-06-18 09:41:30 +01:00
Matt Pocock
2454c95dc3
Merge pull request #347 from mattpocock/changeset-release/main
chore: version skills
2026-06-17 23:07:39 +01:00
github-actions[bot]
7d684becad chore: version skills 2026-06-17 21:26:49 +00:00
Matt Pocock
aa024cb195 feat: enhance teach skill to prioritize reusable components from ./assets 2026-06-17 22:26:34 +01:00
Matt Pocock
d20ee2684e feat: let teach skill share code between lessons via ./assets
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-17 22:18:21 +01:00